Ruby on Rails

Comments and changes to this ticket

• 

  Christopher J. Bottaro July 8th, 2008 @ 12:29 PM

  I forgot to mention, this patch is for Rails 2.1.0.

• 

  Pratik July 14th, 2008 @ 08:49 AM

  • → Assigned user changed from “” to “Joshua Peek”
• 

  Repository July 15th, 2008 @ 09:58 PM

  • → State changed from “new” to “resolved”

  (from [be078ee162fcae883a5621a30929879cd783a238]) Run callbacks from object's metaclass [#575 state:resolved]

  http://github.com/rails/rails/co...

• 

  Joshua Peek July 16th, 2008 @ 09:26 PM

  • → State changed from “resolved” to “open”

  We had to revert this. Apparently it broke a ton of shit.

  Maybe we don't want callbacks on the metaclass, but a set of callbacks for objects as well as classes.

  Lets try a new API

  module ModuleWithCallbacks
    def self.extended(obj)
      obj.before_save :module_callback
    end
  
    def module_callback
      # ...
    end
  end
  
  p = Person.new
  p.extend(ModuleWithCallbacks)
  
  # or also do
  p.before_save :module_callback
  def p.module_callback
    ...
  end
  

  We could have a instance variable on the object that tracks its callbacks

• 

  Christopher J. Bottaro July 16th, 2008 @ 09:55 PM

  Just out of curiosity, what did it break?

  It broke our webapp because we try to serialize AR instances and it complained about not being able to serialize the object's metaclass. We just decided that we shouldn't have been serializing AR instances in the first place, heh.

• 

  Christopher J. Bottaro July 16th, 2008 @ 09:59 PM

  Btw, your solution of having callback chains on classes as well as instances of classes (objects) sounds great.

• 

  Joshua Peek July 18th, 2008 @ 07:30 PM

  Check out the latest Memoizable stuff for reference.

  http://github.com/rails/rails/tr...

  I've been playing around with a pattern that works for Classes and Objects.

  I don't have time to work on this right now, but I do plan to get back to in in the next coming weeks.

  (BTW, I'm getting obsessed with "object-oriented"/prototype driven development)

• 

  Joshua Peek July 22nd, 2008 @ 10:30 AM

  • → State changed from “open” to “wontfix”

  It looks like this is going take alot more work. If you ever decide its worth pursuing, open and new ticket for refactoring Callbacks and assign it to me.