SQL queries with WHERE IN are incorrectly generated for named scopes
Reported by Szymon Nowak | July 9th, 2008 @ 11:17 AM | in 2.x
class Post < ActiveRecord::Base
named_scope :recent, :conditions => [...]
end
class Author < ActiveRecord::Base
belongs_to :post
end
posts = Post.recent
Author.find_all_by_post_id(posts)
This generates the following query:
SELECT * FROM `authors` WHERE (`authors`.`post_id` = 107,108,109)
instead of using WHERE IN clause.
Casting ActiveRecord::NamedScope::Scope object into Array object using posts.to_a fixes the problem, but it should be done automatically by dynamic finder method.
Comments and changes to this ticket
-
Philip Hallstrom August 15th, 2008 @ 06:54 AM
- → Tag changed from 2.1 activerecord bug named_scope to 2.1 activerecord bug named_scope patch
- → Title changed from SQL queries with WHERE IN are incorrectly generated for named scopes to PATCH: SQL queries with WHERE IN are incorrectly generated for named scopes
Below is a patch that fixes this. It has a slight drawback in that in cases where the named scope only returns one value it will generate "WHERE id IN (123)" which may or may not be more efficient than "WHERE id = 123" depending on the database.
It looks like making it smart enough to optimize that out would require additional changes as one would need to check the length of the Scope and where this code is being generated only the class name is available as an argument.
diff --git a/activerecord/lib/active_record/base.rb b/activerecord/lib/active_record/base.rb index 92a24ec..5d3a86f 100755 --- a/activerecord/lib/active_record/base.rb +++ b/activerecord/lib/active_record/base.rb @@ -1717,7 +1717,7 @@ module ActiveRecord #:nodoc: def attribute_condition(argument) case argument when nil then "IS ?" - when Array, ActiveRecord::Associations::AssociationCollection then "IN (?)" + when Array, ActiveRecord::Associations::AssociationCollection, ActiveRecord::NamedScope::Scope then "IN (?)" when Range then "BETWEEN ? AND ?" else "= ?" end -
Pratik August 16th, 2008 @ 08:23 PM
- → Title changed from PATCH: SQL queries with WHERE IN are incorrectly generated for named scopes to SQL queries with WHERE IN are incorrectly generated for named scopes
-
Pratik August 16th, 2008 @ 08:32 PM
- → State changed from new to incomplete
Missing tests. Also, please check http://rails.lighthouseapp.com/p...
Thanks.
-
Philip Hallstrom August 18th, 2008 @ 09:11 PM
- no changes were found...
-
-
Pratik August 18th, 2008 @ 09:14 PM
- → State changed from incomplete to open
-
-

Repository August 21st, 2008 @ 04:12 PM
- → State changed from open to resolved
(from [49c0e1e594c95d7e8446ebabecc9147afa62de7d]) Fix generated WHERE IN query for named scopes. [#583 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
-

Repository August 25th, 2008 @ 09:31 AM
(from [2092f26edbd6de6d542a7bbd5b4dd30d5fd66ef4]) Fix generated WHERE IN query for named scopes. [#583 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
