Print controller module into request log
Reported by Dmitry Sokurenko | July 10th, 2008 @ 09:38 PM | in 2.x
Currently ActionController request log contains only controller class name, without module, like
Processing UsersController#index ...
When you put half of you controllers in modules, like UsersController and Admin::UsersController, then the absence of module in the log becames a problem. Mostly for log analysis tools, and for situations when you encounter some routing bugs and can't undersand what controller processed the request.
So I think it would be better to have such output:
Processing Admin::UsersController#index ...
So there is a patch to fix it.
Comments and changes to this ticket
-
Clemens Kofler July 11th, 2008 @ 10:14 AM
- → Tag changed from “actionpack controller enhancement patch” to “actionpack controller enhancement patch tested”
+1 from me. It passes the tests and makes total sense.
-
Clemens Kofler July 11th, 2008 @ 10:47 AM
Little note: A single test fails ->
1) Failure:
test_action_cache_conditional_options(ActionCacheTest)
[./test/controller/caching_test.rb:290:in `test_action_cache_conditional_options'
./test/../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:91:in `__send__'
./test/../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:91:in `run']:
is not true.
But this also fails w/o the patch so I don't think it's related.
-
-
Repository July 17th, 2008 @ 01:34 AM
- → State changed from “new” to “resolved”
(from [f7fdbae770275ccbc277c42287b9783cb00fa9fa]) Use fully-qualified controller name when logging. [#600 state:resolved]
Signed-off-by: Pratik Naik
-
Repository August 25th, 2008 @ 09:27 AM
(from [6fbd6c0a009e4848b9cd2e0a055b8ecdb867049f]) Use fully-qualified controller name when logging. [#600 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
Pratik