Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Inconsistent functionality in date_helper.rb

#606

I was working on some doc patches for the date/datetime helpers when I found out that there are some inconsistencies. IMO, all date helpers (both, object related and standard ones) should support the same options to define separators. This applies for all compound helpers - i.e. date/datetime/time_select and select_date/datetime/time.

Code examples:

# standard:
select_date(date, :date_separator => ' / ') # should work, but doesn't
select_datetime(date, :date_separator => ' / ') # should work AND is documented, but doesn't work
select_datetime(date, :datetime_separator => ' , ') # works, but isn't documented
select_datetime(date, :time_separator => ' - ') # should work, but doesn't
select_time(time, :time_separator => ' - ') # works

# object related:
date_select(object, method, :date_separator => ' / ') # should work, but doesn't
datetime_select(object, method, :datetime_separator => ' , ', :date_separator => ' / ', :time_separator => ' - ') # should work, but doesn't
time_select(object, method, :time_separator => ' - ') # should work, but doesn't

It's nothing big and it seems it's hardly ever used (otherwise, someone would have complained already) but I think it should be fixed nevertheless because it makes the date helper API inconsistent.

I've attached the failing tests for now and I'll try to come up with a patch in a day or two.

Reported by Clemens Kofler · July 12th, 2008 @ 08:52 PM

State: resolved
Milestone: none
Assigned to: josh josh
Importance: none

Activity

  1. Emilio Tagua
    Emilio Tagua
    • Tag changed from actionpack, enhancement, helper, tests to actionpack, enhancement, helper, patch, tests

    I attach a patch that fixes all this tests and make date helpers to work as expected in docs.

    I had to modify a test that had wrong parameters. As for the rest, many thanks to Clemens for providing such good tests with the description of the problem.

    July 17th, 2008 @ 05:08 PM

  2. Emilio Tagua
  3. Jeremy Kemper
    Jeremy Kemper
    • Assigned user set to josh
    • State changed from new to open
    • Milestone changed from 2.x to 2.1.1

    July 30th, 2008 @ 10:04 AM

  4. Clemens Kofler
    Clemens Kofler

    Info:

    Josh and I are working on unifying the interface by taking out functionality of the InstanceTag class and moving it into its own presenter layer.

    If you want to follow the progress, just watch the relevant branch at GitHub: http://github.com/josh/rails/tre...

    July 30th, 2008 @ 10:10 AM

  5. josh
    josh

    Clemens, could you roll these patches into our presenter refactor.

    July 31st, 2008 @ 07:29 PM

  6. Clemens Kofler
    Clemens Kofler

    Definitely, Josh. Once we're done this should work anyway since both types would use the same backend.

    July 31st, 2008 @ 08:35 PM

  7. Clemens Kofler
  8. josh
    josh
    • Milestone cleared.

    August 7th, 2008 @ 06:49 AM

  9. josh
    josh
    • State changed from open to resolved

    Resolving as we are committing shortly.

    August 7th, 2008 @ 04:51 PM