#614 new
Antonio Cangiano

Fix SQLite's db creation warnings

Reported by Antonio Cangiano | July 13th, 2008 @ 04:00 PM | in 2.x

Running rake db:create (or rake db:create:all) results in an error message such as, "db/development.sqlite3 already exists". The error message is always printed regardless of whether the database already existed or not.

This is due to the fact that the create_database method in railties/lib/tasks/database.rake wrongly assumes that the following two lines attempt a connection only: 

ActiveRecord::Base.establish_connection(config)
ActiveRecord::Base.connection

In reality, the SQLite adapter will automatically create the database if it doesn't exist already and no errors are raised. Therefore the else clause of the begin/rescue statement is invoked every time, in turn printing the message mentioned above.

The attached patch fixes this.

Comments and changes to this ticket

Please Login or create a free account to add a new comment.

You can update this ticket by sending an email to from your email client. (help)

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Source available from github

The Git repository resides at http://github.com/rails

Check out the current development trunk (Edge Rails) with:

git clone git://github.com/rails/rails.git

The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.

Creating a bug report

When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.

Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.

Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".

Shared Ticket Bins

Attachments

People watching this ticket

Tags