Add in place versions of compact, uniq, flatten to Array.prototype
Reported by matthuhiggins | April 29th, 2008 @ 07:13 PM
Given that prototype is modeled after Ruby, it seems like the in place '!' versions of these functions are missing. Since Array.prototype.reverse already takes an optional 'inline' parameter, it seems inconsistent that these other functions do not support it.
Let me try to hand type a rough version in this little text box:
_compact: function() {
var index = 0, last = this.length - 1;
while(index <= last) {
if (this[last] == null) {
last--;
} else if (this[index] == null) {
this[index++] = this[last--];
} else {
index++;
}
}
this.length = last + 1;
return this;
},
compact: function(inline) {
return (inline !== false ? this : this.toArray())._compact();
}
...
(Apologies if I am bringing up an old subject that has already been shot down.)
Comments and changes to this ticket
-
Frederick Cheung April 29th, 2008 @ 07:42 PM
This should be on the prototype light house (http://prototype.lighthouseapp.com/)
-
matthuhiggins April 29th, 2008 @ 08:28 PM
I added this ticket over at prototype.lighthouse. I do not have privileges to close this one.
-
DHH April 30th, 2008 @ 09:40 PM
- → State changed from “new” to “resolved”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
