#621 √ wontfix
Lawrence Pit

find_last_by_* dynamic finder

Reported by Lawrence Pit | July 15th, 2008 @ 02:51 AM | in 2.x

This patch allows the following:

  Account.find_last_by_limit(50)
  Account.find_first_by_limit(50)

Comments and changes to this ticket

  • Tarmo Tänav

    Tarmo Tänav July 15th, 2008 @ 03:41 AM

    I think you forgot to remove the old implementation of determine_finder().

    I'm not sure if find_first_by is a good addition though because one would need to decide between using find_by and find_first_by and in this case a choice creates confusion (ie. do you use 'first_by' because it is more explicit and communicates the meaning of the code better of 'by' because it's shorter, easier to read/write).

  • Lawrence Pit

    Lawrence Pit July 15th, 2008 @ 05:00 AM

    Thanks for the comment. Attached new patch.

  • Pratik

    Pratik July 17th, 2008 @ 12:56 AM

    • → State changed from “new” to “wontfix”

    I don't really think this is needed and will be useful. But please do continue the discussion in mailing list if you think it's really useful.

    Thanks.

Please Login or create a free account to add a new comment.

You can update this ticket by sending an email to from your email client. (help)

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Source available from github

Repository is at http://github.com/rails/rails

Check out the development master (Edge Rails):

git clone git://github.com/rails/rails.git

Creating or reviewing a patch

See the contributor guide.

Creating a feature request

Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.

Creating a bug report

When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.

Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.

Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..

Shared Ticket Bins

People watching this ticket

Attachments