Scaffolded functional tests should test for failed create/update
Reported by Mark Cornick | July 15th, 2008 @ 07:28 PM | in 2.x
Currently, the functional tests generated by the scaffold generator do not test the parts of the create and update actions which handle failed creates/updates. The tests should be updated to cover the entire create and update actions.
This is difficult to accomplish in a way that is both automatic and elegant. We could create new tests passing invalid parameters to the create/update actions, but we do not define any validations at the time that the generator is run, and so we have no way of knowing what constitutes invalid parameters. We could mock the .save and .update_attributes methods to fail, but we cannot depend on the developer having an appropriate mocking library installed. We could dike out the save/update methods with sneaky uses of the private define_method call, but that approach is ugly.
The attached patch simply defines two new tests, one for create and one for update, with the same parameters as the original tests, but expecting the operation to fail instead of to succeed. It also includes FIXME notes stating that these tests will fail until validations are added to the model and the tests are updated with parameters that fail those validations.
I expect this change to be controversial, in that scaffold-generated tests will now fail out of the box. My rationale is that if we consider scaffolding to be an educational tool (see http://groups.google.com/group/r..., doing it this way will help the developer learn to write tests; besides, the sort of people who are inclined to not run tests won't notice the failure anyway (and those who are so inclined will either fix the tests to pass, or remove them entirely.)
Comments and changes to this ticket
-
Joshua Peek October 28th, 2008 @ 04:25 PM
- → State changed from “new” to “stale”
Staling out, please reopen if this is still a problem.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
