form authentication interfering with page layout
Reported by Kevin Chiu | July 15th, 2008 @ 06:34 PM | in 2.x
Rails automatically inserts these snippets to help authenticate forms:
<div style="margin: 0pt; padding: 0pt;">
<input type="hidden" value="put" name="_method"/>
<input type="hidden" value="461f8f380f7920fd06015c1d2541c23e71f11d8c" name="authenticity_token"/>
</div>
Occasionally, CSS styling overflows into these divs. However, it is impossible to remove the overflow from these divs because the divs do not have associated class names.
Suggested solution: Add class="hidden" to the div or just add the style to hide it.
Comments and changes to this ticket
-
rick July 15th, 2008 @ 06:58 PM
- → State changed from “new” to “open”
Should there be a global rails namespace for rails-generated classes? "hidden" seems like it'd be a pretty common class.
rails-hidden-inputs? -
Kevin Chiu July 15th, 2008 @ 07:10 PM
That would work. As a side benefit, it would also help people looking over
output code understand what is generated by Rails and what is not.
On Tue, Jul 15, 2008 at 7:58 PM, Lighthouse
wrote:
-
uncubicled July 17th, 2008 @ 11:49 AM
- no changes were found...
-
uncubicled July 17th, 2008 @ 11:49 AM
- → Tag changed from “2.1 bug” to “2.1 actionpack enhancement patch tested tests”
Implementet this. Wrapping div gets class 'rails-hidden-inputs' when an element has type="hidden". If my implementation is too shady, there is at least updated tests for the div class.
-
uncubicled July 17th, 2008 @ 11:59 AM
Namespacing, in the pure sense, went out the window, since all hidden elements get tagged with rails-hidden-*inputs*. But as far as I can see, all hidden elements generated by rails are input fields. As least as far as the tests go. Its a hack, I know. I needed something bite-size to poke my fingers at.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
