named_scope with eager loading affects activerecord objects
Reported by elDub | July 17th, 2008 @ 04:29 PM | in 2.x
Named scope with eager loading seems to affect activerecord objects to the point in which the object's relationships are broken.
Take this example class...
class Document < ActiveRecord::Base
has_one :revision, :class_name => 'Document', :foreign_key => 'prior_revision_id'
belongs_to :prior_revision, :class_name => 'Document', :foreign_key => 'prior_revision_id'
named_scope :active, :conditions => { :active => true }
named_scope :inactive, :conditions => { :active => false }
named_scope :both, :conditions => { :active => [true,false] }
end
...and this setup...
script/console
Loading development environment (Rails 2.1.0)
>> doc = Document.create(:active => false)
=> #<Document id: 1, prior_revision_id: nil, active: false, created_at: "2008-07-17 15:18:44", updated_at: "2008-07-17 15:18:44">
>> doc.create_revision(:active => true)
=> #<Document id: 2, prior_revision_id: 1, active: true, created_at: "2008-07-17 15:18:58", updated_at: "2008-07-17 15:18:58">
A basic test works...
>> test1 = Document.inactive.find(:first)
=> #<Document id: 1, prior_revision_id: nil, active: false, created_at: "2008-07-17 15:18:44", updated_at: "2008-07-17 15:18:44">
>> test1.revision
=> #<Document id: 2, prior_revision_id: 1, active: true, created_at: "2008-07-17 15:18:58", updated_at: "2008-07-17 15:18:58">
However, using eager loading, the scope has caused the resulting activerecord object to NOT be able to see the revision relationship.
>> test2 = Document.inactive.find(:first, :include => :revision)
=> #<Document id: 1, prior_revision_id: nil, active: false, created_at: "2008-07
-17 15:18:44", updated_at: "2008-07-17 15:18:44">
>> test2.revision
=> nil
I assume that because the revision relationship is itself of the Document class that THAT is the reason why it was not returned (it is active and the named scope was looking for inactive), though I don't agree that the relationship should be scoped. If the named scope is changed from 'inactive' to 'both', the revision relationship is visible.
To further confuse things, if I instead collect all the matching documents with an order clause referencing the join, things are back to normal.
>> test3 = Document.inactive.find(:all, :include => :revision, :order => 'revisions_documents.id')[0]
=> #<Document id: 1, prior_revision_id: nil, active: false, created_at: "2008-07-17 15:18:44", updated_at: "2008-07-17 15:18:44">
>> test3.revision
=> #<Document id: 2, prior_revision_id: 1, active: true, created_at: "2008-07-17 15:18:58", updated_at: "2008-07-17 15:18:58">
Comments and changes to this ticket
-

elDub September 19th, 2008 @ 05:49 PM
- → Tag changed from 2.1 activerecord bug eager_loading has_one named_scope to 2.1 activerecord bug eager_loading has_one named_scope
Added failing test case.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
