mail_to :javascript should use decodeURIComponent instead unescape
Reported by Marc-André Lafortune | July 17th, 2008 @ 04:45 PM | in 2.x
If the 'name' parameter for mail_to contains unicode characters, these will not show properly in the link. Solution involves using to_json before outputing each byte.
Example:
mail_to "xxx@example.com", "Écris-nous", :encode=>:javascript
The link's label will show as "Ãcris-nous".
Solution:
Modify mail_to's code:
- "document.write('#{content_tag("a", name || email_address, html_options.merge({ "href" => "mailto:"+email_address+extras }))}');".each_byte do |c|
+ "document.write('#{content_tag("a", (name || email_address).to_json[1..-2], html_options.merge({ "href" => "mailto:"+email_address+extras }))}');".each_byte do |c|
Temporary solution for affected users: call to_json yourself, as in:
mail_to "xxx@example.com", "Écris-nous", :encode=>:javascript
Comments and changes to this ticket
-
Marc-André Lafortune July 17th, 2008 @ 04:50 PM
Oups, managed to screw up my very first ticket... The example should read:
mail_to "xxx@example.com", "Écris-nous", :encode=>:javascriptand the temporary fix:
mail_to "xxx@example.com", "Écris-nous".to_json[1..-2], :encode=>:javascript -
miloops July 31st, 2008 @ 03:30 PM
- → Title changed from “mail_to :javascript screws up unicode” to “mail_to :javascript should use decodeURIComponent instead unescape”
- → Tag changed from “” to “actionpack helper patch”
Instead of using unescape to decode the generated string, Rails should use decodeURIComponent since it is utf-8 friendly.
I attach the patch and test, i have also tested in browsers that the escaped javascript is the expected.
-
Michael Koziarski August 8th, 2008 @ 08:31 AM
- → State changed from “new” to “committed”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
