create_table with options hash
Reported by Justin Marney | July 18th, 2008 @ 07:38 PM | in 2.x
create_table currently accepts an options string which defaults to 'Engine=InnoDB'. Adding additional options such as 'CHARACTER SET' causes the default 'ENGINE=InnoDB' to be overwritten. This patch allows options to be submitted via a hash and the default Engine=InnoDB is then reverse merged. This patch also preserves the previous string based functionality.
Comments and changes to this ticket
-
Clemens July 19th, 2008 @ 06:19 AM
- → Tag changed from “migrations patch tested” to “activerecord migrations patch tests”
I think this would be a bad idea because this way you can't specify stuff that isn't in the key=value format like e.g. partition options. Look at the CREATE TABLE docs for MySQL for example.
What you could probabably do instead is have a Regexp that checks if the ENGINE option is set and otherwise default it to InnoDB.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
