Optional NULL via condition hash
Reported by spyfalcon | July 20th, 2008 @ 11:09 AM | in 2.x
The following code:
Page.find(:all, :conditions => { :author => ['Anonymous', nil]})
resutls in an SQL query like this:
[...] WHERE `author` IN ('Anonymous', NULL)
However, it does not return any pages with author = nil/NULL (using MySQL).
I fixed this by factroing out
active_record/base.rb in sanitize_sql_hash_for_conditions
"#{table_name}.#{connection.quote_column_name(attr)} #{attribute_condition(value)}"
into a new method, advanced_attribute_condition. It checks for an array-argument including nil and builds the SQL snippet accordingly. For example:
{ :author => ['Anonymous', nil] } #=> [...] WHERE (author = 'Anonymous' OR author IS NULL)
{ :type => ['a', 'b', nil] } #=> [...] WHERE (type IN ('a', 'b') OR type IS NULL)
This may also be handy when working with LEFT OUTER JOIN, as conditions affecting a associated table result in a RecordNotFound if no matching record can be found in it.
Comments and changes to this ticket
-
Pratik July 20th, 2008 @ 06:37 PM
- → State changed from “new” to “wontfix”
- → Assigned user changed from “” to “Pratik”
I understand that this is an issue. But I don't think this corner case justifies the added complexity in the code.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
