Dynamic scopes and dynamic finders for belongs_to
Reported by Lawrence Pit | July 21st, 2008 @ 09:43 AM | in 2.x
This patch consists of two changes:
1. the dynamic finders now accept belongs_to attributes.
2. attributes that can be used via a dynamic finder can also be directly accessed as scopes.
Example usages include:
comments = Comment.find_by_creator(current_user)
comments = Comment.creator(current_user).commentable(post).all
posts = Post.creator(current_user).published.my_named_scope.last
cases = Case.status("OPEN").priority("HIGH").my_named_scope.all
The main advantage of this patch is that it allows easy formation of dynamic queries based on input, without needing to explicitly define named scoped in your models. For example:
scope = Comment.scoped({:include => [:creator, :commentable]})
scope = scope.commentable(post) if post
scope = scope.university(params[:uni]) if params[:uni]
scope = scope.creator(current_user) if params[:created_by_me] == "1"
scope = scope.country(params[:country]) if params[:country]
@comments = scope.all
Comments and changes to this ticket
-
Pratik July 21st, 2008 @ 02:37 PM
- → Assigned user changed from “” to “Michael Koziarski”
-
Ryan Bates July 21st, 2008 @ 03:47 PM
I think it's preferable to go through the has_many association whenever possible. So you could do this in the first example.
comments = current_user.commentsBut for cases where you need to search on multiple belongs_to associations then I could see this being really useful.
-
Tom Locke July 21st, 2008 @ 06:12 PM
This seems to be a bit at risk of name clashes, the following slight change might help and is perhaps more readable:
Comment.creator_is(current_user)Then you can also have the negative form, e.g.:
my_post.comments.creator_is_not(some_user)I also have an implementation of these and many more which I'm intending to release as a plugin.
-
Joshua Peek October 28th, 2008 @ 04:30 PM
- → State changed from “new” to “stale”
Staling out, please reopen if this is still a problem.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
Michael Koziarski
Tarmo Tänav