activesupport's to_xml shouldn't modify options hash
Reported by David Burger | July 22nd, 2008 @ 12:04 AM | in 2.x
This patch changes the to_xml core extensions for Array and Hash so that they dup the options hash instead of modifying the passed in version. The current behavior, as demonstrated in script/console, looks like this:
>> options = {:skip_instruct => true}
=> {:skip_instruct=>true}
>> [].to_xml(options)
=> "<nil-classes type=\"array\"/>\n"
>> options
=> {:builder=><nil-classes type="array"/>
<inspect/>
, :indent=>2}
>>
Notice the options hash has been modified by the to_xml call. With included patch, the options hash is not modified:
>> options = {:skip_instruct => true}
=> {:skip_instruct=>true}
>> [].to_xml(options)
=> "<nil-classes type=\"array\"/>\n"
>> options
=> {:skip_instruct=>true}
Comments and changes to this ticket
-
-
Clemens July 22nd, 2008 @ 06:10 AM
Good one. Not duping the options hash before using it seems to be a problem that's all across Rails.
+1
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
