Let observers create after_find if they need it
Reported by George Ogata | July 22nd, 2008 @ 04:19 PM | in 2.x
Ticket #625 removed the line that caused observers to define an after_find method in the model if it didn't exist yet. This caused a speed-up (defining after_find can slow things down), but for cases where after_find is observed and not defined in the model, it means that an empty after_find must be explicitly defined in the model. It can be tricky to work out why an observer is failing due to this.
This patch restores the previous behavior, but only if the observer actually has an after_find defined. Hopefully, this offers the best of both worlds.
Comments and changes to this ticket
-
-
Pratik July 26th, 2008 @ 09:20 AM
- → Assigned user changed from “” to “Michael Koziarski”
-
Repository July 26th, 2008 @ 09:26 AM
- → State changed from “new” to “resolved”
(from [e8fc894f66daa7909d1790f2cd145844d256d282]) Make observers define #after_find in the model only if needed.
[#676 state:resolved]
Signed-off-by: Michael Koziarski
-
Repository August 25th, 2008 @ 03:28 AM
(from [473d8d04624cb5e699759eb9d41d52f1323122dd]) Make observers define #after_find in the model only if needed.
[#676 state:resolved] Signed-off-by: Michael Koziarski michael@koziarski.com http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
Michael Koziarski