ActiveResource instance.valid? has no validate callbacks
Reported by Hugh | July 22nd, 2008 @ 11:08 PM | in 2.x
Taking an example from the docs:
class Person < ActiveResource::Base
self.site = "http://www.localhost.com:3000/"
protected
def validate
errors.add("phone_number", "has invalid format") unless phone_number =~ /[0-9]*/
end
end
As you can see valid? does not trigger any callbacks like ActiveRecord:
person = Person.new("first_name" => "Jim", "phone_number" => "I will not tell you.")
person.valid? # => true
person.errors.add("phone_number", "has invalid format") unless :phone_number =~ /[0-9]*/
person.valid? # => false
Comments and changes to this ticket
-
Smilinguy July 27th, 2008 @ 12:58 AM
I'm also having the same issue where my validate method is not called on valid?.
In fact, my validate isn't even called on save! unless there have been attributes modified.
In my case, these objects were created before I added new validation rules. If I try and save! them now, I would expect them to fail validation but they don't.
-
Paul Horsfall July 30th, 2008 @ 07:06 AM
I think that all validation in Active Resource is done by the remote service. There's "an old patch on Trac":
http://dev.rubyonrails.org/ticke... to fix the documentation which I was thinking about reviving to clear things up. Should I?
-
Tim Morton August 18th, 2008 @ 11:04 AM
I would vote in favor of fixing the code to match the docs, not vice versa. Local validations are useful.
See http://www.akitaonrails.com/2008... for a start.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
