NamedScope#any?
Reported by Jan De Poorter | July 23rd, 2008 @ 11:53 AM | in 2.x
When I call any? without a block on an Association I get this SQL query:
user.pages.any?
SQL (0.000356) SELECT count(*) AS count_all FROM `pages` WHERE (`pages`.user_id = 114564551)
When I do the same on a NamedScope I get this:
user.pages.active.any?
SQL (0.000331) SELECT * FROM `pages` WHERE (`pages`.user_id = 114564551) AND (`pages`.`status` = 'active')
The attached patch does a count like it allready happens on associations.
Comments and changes to this ticket
-
Tarmo Tänav July 23rd, 2008 @ 11:57 AM
Actually neither should be doing count() as exists?({}) is much faster (it's faster to fetch one record compared to counting them all).
-
Tarmo Tänav July 23rd, 2008 @ 11:59 AM
Ofcourse exists?() should not be used in case the records are already loaded.
-
Repository July 23rd, 2008 @ 12:05 PM
- → State changed from “new” to “resolved”
(from [93e10f9911fb2a096681ee0a0bc82487a9a06c44]) Ensure NamedScope#any? uses COUNT query wherever possible. [#680 state:resolved]
Signed-off-by: Pratik Naik
-
Paweł Kondzior August 6th, 2008 @ 08:55 PM
Method
any?is not the same as!empty?[nil].any? will return false [nil].empty? will return false
But maybe here there is no case when AR can return [nil,nil,nil] array. But i think rails shouldn't break MRI here.
-
Tarmo Tänav August 7th, 2008 @ 08:44 AM
If there was a case where an association would return [nil] it would by itself be an error in AR so there can't be a a case where any? on associations wcould behave differently than on arrays.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
