image_tag adds strange dot after file names on windows
Reported by iGEL | July 24th, 2008 @ 10:33 AM | in 2.x
On Windows, File#exist?("example.txt.") returns true, if example.txt exists (note the dot at the end). Because of that, methods like image_tag add a dot at the end of the file name.
Fix:
Change actionpack/lib/action_view/helpers/asset_tag_helper.rb:477 from:
source += ".#{ext}" if ext && File.extname(source).blank? || File.exist?(File.join(ASSETS_DIR, dir, "#{source}.#{ext}"))
to:
source += ".#{ext}" if ext && (File.extname(source).blank? || File.exist?(File.join(ASSETS_DIR, dir, "#{source}.#{ext}")))
Lots of assertions failed because of this in my app when I migrated from 1.2.6 to 2.1.0
Comments and changes to this ticket
-
Pratik July 26th, 2008 @ 10:25 PM
- → Assigned user changed from “” to “Pratik”
-
Liam Morley July 26th, 2008 @ 10:42 PM
- → Assigned user cleared.
I just ran into this too. Because of the extra dot, the server doesn't consider 'myfile.png.?123456' to have a .png extension, and sets the content-type to 'application/octet-stream' instead of 'image/png', which means my images don't show up in some finicky mobile web browser, which makes me spend 2 hours hunting down this bug. :/
Seem like this is more of a ruby bug than a rails bug, but the rails code could afford to be little tighter.
-
Liam Morley July 26th, 2008 @ 10:42 PM
- → Assigned user changed from “” to “Pratik”
-
Aslak Hellesøy August 25th, 2008 @ 09:39 AM
This is a Windows bug actually. Try this:
IF EXIST README.txt..... echo Wind0s suX
Awesome stuff
-
Aslak Hellesøy August 25th, 2008 @ 09:45 AM
Some interesting links mentioning trailing dots in file names on windows:
http://www.fs-driver.org/relnote... http://osdir.com/ml/security.bug... (a 6 year old bug that they never really fixed, just worked around...)
Since Redmond will probably never fix this bug, I guess the buest fix in Rails is to avoid code like
File.exist?(File.join(ASSETS_DIR, dir, "#{source}.#{ext}"))
When ext may be nil or an empty string...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
JerryWho