has_one through with new value nil
Reported by Daniel Guettler | July 24th, 2008 @ 08:06 PM | in 2.x
I ran into this when I tried to set a has_one through association to nil. ActiveRecord correctly removed the through association from the database but then it tried to create a new association using nil as associate.
class Member < ActiveRecord::Base
has_one :current_membership
has_one :club, :through => :current_membership
end
class CurrentMembership < Membership
belongs_to :member
belongs_to :club
end
class Club < ActiveRecord::Base
end
@member.club = nil
Attached a patch with failing test and possible fix.
Comments and changes to this ticket
-
Joshua Peek October 28th, 2008 @ 04:32 PM
- → State changed from “new” to “stale”
Staling out, please reopen if this is still a problem.
-
Daniel Guettler October 28th, 2008 @ 06:38 PM
Yes this is still a problem, I just tried it with the current edge version of rails and got:
RuntimeError: Called id for nil, which would mistakenly be 4 -- if you really wanted the id of nil, use object_id from /Users/dguettler/workspace/my_projects/rails_testings/has_one_nil/vendor/rails/activerecord/lib/active_record/associations/has_many_through_association.rb:100:in `construct_join_attributes' from /Users/dguettler/workspace/my_projects/rails_testings/has_one_nil/vendor/rails/activerecord/lib/active_record/associations/has_one_through_association.rb:15:in `create_through_record' from /Users/dguettler/workspace/my_projects/rails_testings/has_one_nil/vendor/rails/activerecord/lib/active_record/associations.rb:1265:in `club=' from (irb):7 -
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
Tarmo Tänav