ActionView::Helpers::FormOptionsHelper COUNTRIES constant controversally labels Taiwan a province of China
Reported by coolblade | July 28th, 2008 @ 07:43 PM | in 2.x
Regardless of where you stand on the issue I think for now it is safe to say let's just label Taiwan as Taiwan which seems the most neutral stance to the issue. Simple patch included with the COUNTRY constant adjusted.
Comments and changes to this ticket
-
Michael Koziarski July 28th, 2008 @ 08:03 PM
- → State changed from “new” to “wontfix”
Firstly I'm sorry for the controversy this list has caused your customers.
The list as it stands come from the ISO standard # 3166, and is the best neutral option for us when it comes to finding a country list. Whatever faults the list may have, it comes from UN sources.
http://www.iso.org/iso/country_c...
Making the change you suggest may seem from your perspective to be returning the list to a neutral state, but it's likely to be perceived by others as a provacative statement in support of taiwanese independence.
We won't accept patches which cause this list to differ from the ISO list, I'm sorry. You can make the changes in your own application relatively easily, and I'd suggest that that's the best option for you.
-
coolblade July 28th, 2008 @ 08:14 PM
Michael,
No argument there, I didn't realize that it is an ISO list which would be the most neutral stance for rails. I think it might also be worth somehow labeling it as the iso country list since that may be useful to a developer to know the origin. Thanks for the quick response.
-
Michael Koziarski July 28th, 2008 @ 08:24 PM
Thanks for being so understanding, I may well add some documentation about that list. We had a recent case where someone got in trouble because of it mentioning palentinian territories.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
