Deprecating ActiveRecord::Base#attributes=
Reported by Hampton Catlin | July 30th, 2008 @ 12:18 AM | in 2.x
This is an extremely ugly method that is not ruby like enough and its been around since the beginning.
We discussed this in #ruby-contrib and everyone agreed. So, I branched and fixed it.
The new method that merges in attributes is ActiveRecord::Base#merge_attributes instead of ActiveRecord::Base#attributes= which is misleading because it looks like assignment.
I have added a deprecation warning to the use of ActiveRecord::Base#attributes=
There is a pull request on GitHub for this patch.
Comments and changes to this ticket
-
rick July 30th, 2008 @ 01:15 AM
- → State changed from “new” to “open”
Hey, we upload patches to Lighthouse instead of using pull requests. Pull requests are private, and publicly uploaded patches allow everyone that doesn't happen to get a pull request to participate in the testing of the patch.
-
Hampton Catlin July 30th, 2008 @ 01:30 AM
It won't let me upload a patch. Keeps failing.
On Tue, Jul 29, 2008 at 8:15 PM, Lighthouse wrote:
-
Pratik August 22nd, 2008 @ 02:46 AM
- → State changed from “open” to “wontfix”
I think we need a discussion on this on mailing list before we deprecate it.
Thanks.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
