config.load_paths should also be frozen
Reported by José Valim | July 30th, 2008 @ 03:46 PM | in 2.x
On Rails::Initializer, configuration.load_once_paths is frozen but config.load_paths is not.
We need to freeze them so future modifications will fail rather than do nothing mysteriously. For example, I was changing the variable on my environment/development.rb and the path I was setting was never loaded.
To fix, just add the line:
configuration.load_paths.freeze
To railties/lib/initializer.rb, method set_autoload_paths, around line 214.
So we will have:
def set_autoload_paths
Dependencies.load_paths = configuration.load_paths.uniq
Dependencies.load_once_paths = configuration.load_once_paths.uniq
extra = Dependencies.load_once_paths - Dependencies.load_paths
unless extra.empty?
abort <
load_once_paths must be a subset of the load_paths.
Extra items in load_once_paths: #{extra * ','}
end_error
end
configuration.load_once_paths.freeze
end
Comments and changes to this ticket
-
José Valim July 30th, 2008 @ 03:47 PM
Ops:
def set_autoload_paths Dependencies.load_paths = configuration.load_paths.uniq Dependencies.load_once_paths = configuration.load_once_paths.uniq extra = Dependencies.load_once_paths - Dependencies.load_paths unless extra.empty? abort <<-end_error load_once_paths must be a subset of the load_paths. Extra items in load_once_paths: #{extra * ','} end_error end # Freeze the arrays so future modifications will fail rather than do nothing mysteriously configuration.load_paths.freeze configuration.load_once_paths.freeze end -
Repository October 30th, 2008 @ 08:52 PM
- → State changed from “new” to “resolved”
(from [2dcdcf1552748f331bf6f6194ffddabd837bcac9]) config.load_paths should be frozen [#728 state:resolved] http://github.com/rails/rails/co...
-
Repository October 30th, 2008 @ 09:28 PM
(from [fc215de52fe1967bb00b5500c3d0dd2ad55880ac]) Revert "config.load_paths should be frozen [#728 state:resolved]"
This reverts commit 2dcdcf1552748f331bf6f6194ffddabd837bcac9. http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
