has_many :through with custom primary keys
Reported by Justin Marney | July 31st, 2008 @ 09:43 PM | in 2.x
Given the following model:
Owner -has_many-> Bikes -has_many-> Spokes
class Owner
has_many :bikes
has_many :spokes, :through => :bikes
end
hmt will create an invalid sql statement for owner.spokes if set_primary_key is used. The source_primary_key was not pointing to the right primary key, but since all pks are 'id' in a normal rails model this problem was only seen when set_primary_key was used. This patch resolves the issue by changing the source_primary_key from @reflection.klass.primary_key to @reflection.through_reflection.klass.primary_key.
Comments and changes to this ticket
-
Justin Marney July 31st, 2008 @ 09:51 PM
for more discussion see: http://www.ruby-forum.com/topic/...
-
Justin Marney July 31st, 2008 @ 09:54 PM
IGNORE THE ABOVE LINK
Sorry pasted the wrong link. Go HERE http://www.ruby-forum.com/topic/... for more discussion.
-
Peter Liu October 2nd, 2008 @ 08:33 AM
I have the same problem and have been pulling my hair out for days. It is a bug and your patch fixed it. I'm still new so I don't know how to apply the patch so I just manually changed that one line and it work. Please include this patch in 2.2.
-
Tim Pope October 21st, 2008 @ 10:36 PM
I should have searched for tickets first as I've solved this independently. I'm attaching a patch because the original no longer applies cleanly. Both patches implement the same solution with tests and get a +1 from me.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
