Fixed AssociationCollection#<< resulting in unexpected values in @target when :uniq => true
Reported by Ernie Miller | August 1st, 2008 @ 04:19 AM | in 2.x
When AssociationCollection#<< is called, it invokes #add_record_to_target_with_callbacks, which doesn't pay any attention to the reflection's :uniq option before pushing to the @target array, and can result in unexpected values showing up in @target until @target is reloaded. This patch resolves this issue.
Comments and changes to this ticket
-
-
wildchild August 7th, 2008 @ 04:24 AM
- → Tag changed from “activerecord enhancement patch” to “activerecord bug patch”
+1 for this feature. Should we fire callbacks for already duplicate records?
In patch:
@target << record unless @reflection.options[:uniq] && @target.include?(record) callback(:after_add, record)
Why not:
unless @target.include?(record) @target << record unless @reflection.options[:uniq] callback(:after_add, record) end
Cheers.
-
Ernie Miller August 7th, 2008 @ 11:46 AM
I debated about that. In the end, since ActiveRecord doesn't actually prevent duplicate records in the DB, but only in the @target array, when :uniq is set, I felt it would be presumptuous to mess with callbacks. There could be a very legitimate bit of data massaging going on there.
-
Michael Koziarski August 8th, 2008 @ 01:50 PM
- → Assigned user changed from “” to “Michael Koziarski”
Shouldn't it raise an exception if you try to do this? Silently ignoring the call seems like a potential cause of lots of bugs.
-
Michael Koziarski August 8th, 2008 @ 02:19 PM
- → State changed from “new” to “resolved”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
