1 true 2008-08-09T08:40:45+01:00 23734 9903 789 checkbox-generation-with-false 250 8994 resolved actionpack helper patch 2008-11-22T19:45:58+00:00 424 Joshua Peek Senthil http://rails.lighthouseapp.com/projects/8994/tickets/789 2.x while migrating one large app I noticed the check_box helper is inconsistent when compared to radio button helper I have written test and minor fix which solves this problem. def test_check_box_true_false actual = check_box_tag "admin",true expected = %(<input id="admin" name="admin" type="checkbox" value="true" />) assert_dom_equal expected, actual #passes actual = check_box_tag "admin",false expected = %(<input id="admin" name="admin" type="checkbox" value="false" />) assert_dom_equal expected, actual #fails end attaching the git commit as diff you can also access it from, my fork git://github.com/railsfactory/rails.git while migrating one large app I noticed the check_box helper is inconsistent when compared to radio button helper I have written test and minor fix which solves this problem. def test_check_box_true_false actual = check_box_tag "admin",true expected = %(<input id="admin" name="admin" type="checkbox" value="true" />) assert_dom_equal expected, actual #passes actual = check_box_tag "admin",false expected = %(<input id="admin" name="admin" type="checkbox" value="false" />) assert_dom_equal expected, actual #fails end attaching the git commit as diff you can also access it from, my fork git://github.com/railsfactory/rails.git <div><p>while migrating one large app I noticed the check_box helper is inconsistent when compared to radio button helper</p> <p>I have written test and minor fix which solves this problem.</p> <p> def test_check_box_true_false actual = check_box_tag "admin",true expected = %() assert_dom_equal expected, actual #passes actual = check_box_tag "admin",false expected = %() assert_dom_equal expected, actual #fails end</p> <p>attaching the git commit as diff</p> <p>you can also access it from, my fork git://github.com/railsfactory/rails.git</p></div> 1 while migrating one large app I noticed the check_box helper is inconsistent when compared to radio button helper I have written test and minor fix which solves this problem. def test_check_box_true_false actual = check_box_tag "admin",true expected = %(<input id="admin" name="admin" type="checkbox" value="true" />) assert_dom_equal expected, actual #passes actual = check_box_tag "admin",false expected = %(<input id="admin" name="admin" type="checkbox" value="false" />) assert_dom_equal expected, actual #fails end attaching the git commit as diff you can also access it from, my fork git://github.com/railsfactory/rails.git <div><p>while migrating one large app I noticed the check_box helper is inconsistent when compared to radio button helper</p> <p>I have written test and minor fix which solves this problem.</p> <p> def test_check_box_true_false actual = check_box_tag "admin",true expected = %() assert_dom_equal expected, actual #passes actual = check_box_tag "admin",false expected = %() assert_dom_equal expected, actual #fails end</p> <p>attaching the git commit as diff</p> <p>you can also access it from, my fork git://github.com/railsfactory/rails.git</p></div> false 2008-08-09T08:40:46+01:00 23734 --- {} 9903 789 checkbox-generation-with-false 0 8994 new actionpack helper 2008-08-09T08:40:46+01:00 23734 Senthil Senthil http://rails.lighthouseapp.com/projects/8994/tickets/789 2.x 2 diff <div><p>diff</p></div> false 2008-08-09T16:41:24+01:00 23734 --- {} 9903 789 checkbox-generation-with-false 0 8994 new actionpack helper 2008-08-09T16:41:24+01:00 23734 Senthil Senthil http://rails.lighthouseapp.com/projects/8994/tickets/789 2.x 1 tests pass <div><p>tests pass</p></div> true 2008-11-22T19:45:54+00:00 23734 --- :tag: actionpack helper :state: new 9903 789 checkbox-generation-with-false 0 8994 resolved actionpack helper patch 2008-11-22T19:45:58+00:00 424 Joshua Peek Senthil http://rails.lighthouseapp.com/projects/8994/tickets/789 2.x 8824acdcd66409c073fbd3ba7a811df9840e16dc text/plain 2008-08-09T08:40:45+01:00 helper_check_box_false_fix.diff 38123 3598 23734 http://rails.lighthouseapp.com/attachments/38123/helper_check_box_false_fix.diff