424 2 true 2008-08-11T16:49:29+01:00 5701 9903 800 filestore-can-only-store-strings 261 8994 resolved activesupport patch 2008-08-14T02:59:40+01:00 424 Joshua Peek Ryan Bates Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/800 2.x It is currently only possible to store strings in FileStore. All other objects are just converted to a string (to_s) so it's not possible to read them back as an object. This behavior is inconsistent with MemCacheStore and MemoryStore. @@@ ruby cache = ActiveSupport::Cache.lookup_store(:file_store, 'tmp/cache') cache.write('foo', {:a => 1}) cache.read('foo') # => "a1" (hash as string) @@@ The attached patch solves this by using Marshal on read/write. Like MemCacheStore this is overridable with the :raw option. Raw is used in fragment caching so that behaves like it used to (since it only stores strings). It is currently only possible to store strings in FileStore. All other objects are just converted to a string (to_s) so it's not possible to read them back as an object. This behavior is inconsistent with MemCacheStore and MemoryStore. @@@ ruby cache = ActiveSupport::Cache.lookup_store(:file_store, 'tmp/cache') cache.write('foo', {:a => 1}) cache.read('foo') # => "a1" (hash as string) @@@ The attached patch solves this by using Marshal on read/write. Like MemCacheStore this is overridable with the :raw option. Raw is used in fragment caching so that behaves like it used to (since it only stores strings). <div><p>It is currently only possible to store strings in FileStore. All other objects are just converted to a string (to_s) so it's not possible to read them back as an object. This behavior is inconsistent with MemCacheStore and MemoryStore.</p> <pre><code class="ruby"> cache = ActiveSupport::Cache.lookup_store(:file_store, 'tmp/cache') cache.write('foo', {:a =&gt; 1}) cache.read('foo') # =&gt; &quot;a1&quot; (hash as string) </code></pre> <p>The attached patch solves this by using Marshal on read/write. Like MemCacheStore this is overridable with the :raw option. Raw is used in fragment caching so that behaves like it used to (since it only stores strings).</p></div> 1 It is currently only possible to store strings in FileStore. All other objects are just converted to a string (to_s) so it's not possible to read them back as an object. This behavior is inconsistent with MemCacheStore and MemoryStore. @@@ ruby cache = ActiveSupport::Cache.lookup_store(:file_store, 'tmp/cache') cache.write('foo', {:a => 1}) cache.read('foo') # => "a1" (hash as string) @@@ The attached patch solves this by using Marshal on read/write. Like MemCacheStore this is overridable with the :raw option. Raw is used in fragment caching so that behaves like it used to (since it only stores strings). <div><p>It is currently only possible to store strings in FileStore. All other objects are just converted to a string (to_s) so it's not possible to read them back as an object. This behavior is inconsistent with MemCacheStore and MemoryStore.</p> <pre><code class="ruby"> cache = ActiveSupport::Cache.lookup_store(:file_store, 'tmp/cache') cache.write('foo', {:a =&gt; 1}) cache.read('foo') # =&gt; &quot;a1&quot; (hash as string) </code></pre> <p>The attached patch solves this by using Marshal on read/write. Like MemCacheStore this is overridable with the :raw option. Raw is used in fragment caching so that behaves like it used to (since it only stores strings).</p></div> false 2008-08-11T16:49:30+01:00 5701 --- {} 9903 800 filestore-can-only-store-strings 0 8994 new activesupport bug patch 2008-08-11T16:49:30+01:00 5701 Ryan Bates Ryan Bates http://rails.lighthouseapp.com/projects/8994/tickets/800 2.x 424 1 Skip the the :raw option and always marshal for consistent behavior. That raw option was only there to pass to memcache-client, we don't need it at the moment. Otherwise I'm down with the idea. <div><p>Skip the the :raw option and always marshal for consistent behavior. That raw option was only there to pass to memcache-client, we don't need it at the moment. Otherwise I'm down with the idea.</p></div> false 2008-08-11T20:59:22+01:00 5701 --- :tag: activesupport bug patch :state: new :assigned_user: 9903 800 filestore-can-only-store-strings 0 8994 open activesupport patch 2008-08-11T20:59:22+01:00 424 Joshua Peek Ryan Bates Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/800 2.x 424 2 Here's a patch which doesn't have the :raw option. I originally thought it was necessary to support old fragment caches when one upgrades, but looks like "nil" will be returned on read if Marshal can't read the cache. Fragment caching is smart enough to rebuild the cache file if that happens (from looking at the code, but I haven't fully tested it). <div><p>Here's a patch which doesn't have the :raw option.</p> <p>I originally thought it was necessary to support old fragment caches when one upgrades, but looks like "nil" will be returned on read if Marshal can't read the cache. Fragment caching is smart enough to rebuild the cache file if that happens (from looking at the code, but I haven't fully tested it).</p></div> false 2008-08-11T21:36:55+01:00 5701 --- {} 9903 800 filestore-can-only-store-strings 0 8994 open activesupport patch 2008-08-11T21:36:55+01:00 5701 Ryan Bates Ryan Bates Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/800 2.x 424 2 Is there an easy to way to still read/write strings without marshaling? Just concerned about the speed impact. <div><p>Is there an easy to way to still read/write strings without marshaling? Just concerned about the speed impact.</p></div> false 2008-08-13T01:53:36+01:00 5701 --- {} 9903 800 filestore-can-only-store-strings 0 8994 open activesupport patch 2008-08-13T01:53:36+01:00 424 Joshua Peek Ryan Bates Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/800 2.x 424 2 It's easy enough to detect if the object is a string on write, but I don't know of a way to tell a normal string vs. a marshalled string on read. This is one reason we may want to keep the :raw option around? That way the developers can optimize their caching with :raw if they are just working with strings. And we can use that in the fragment cache to give a little speed boost since that is always strings. <div><p>It's easy enough to detect if the object is a string on write, but I don't know of a way to tell a normal string vs. a marshalled string on read. This is one reason we may want to keep the :raw option around? That way the developers can optimize their caching with :raw if they are just working with strings. And we can use that in the fragment cache to give a little speed boost since that is always strings.</p></div> false 2008-08-13T17:49:07+01:00 5701 --- {} 9903 800 filestore-can-only-store-strings 0 8994 open activesupport patch 2008-08-13T17:49:07+01:00 5701 Ryan Bates Ryan Bates Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/800 2.x 424 2 Marshal load can take a file object and parse it as it reads the file. It is much faster than reading the whole file into a buffer and than unmarshaling it. After that change, I ran some benchmarks and there is barely any difference between marshaling. Its on all the time. <div><p>Marshal load can take a file object and parse it as it reads the file. It is much faster than reading the whole file into a buffer and than unmarshaling it. After that change, I ran some benchmarks and there is barely any difference between marshaling. Its on all the time.</p></div> true 2008-08-14T02:59:40+01:00 5701 --- :state: open 9903 800 filestore-can-only-store-strings 0 8994 resolved activesupport patch 2008-08-14T02:59:40+01:00 424 Joshua Peek Ryan Bates Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/800 2.x 942f32f04b0b1f3bb67ada32d51a832cdff026c9 text/plain 2008-08-11T16:49:30+01:00 marshal_in_file_store.diff 38404 10830 5701 http://rails.lighthouseapp.com/attachments/38404/marshal_in_file_store.diff ff2d962429641742f77b711fff362534134482bb text/plain 2008-08-11T21:36:55+01:00 marshal_in_file_store_no_raw.diff 38475 2717 5701 http://rails.lighthouseapp.com/attachments/38475/marshal_in_file_store_no_raw.diff