Add :spacer option to render
Reported by Ryan Bates | August 14th, 2008 @ 05:03 PM | in 2.x
Currently the "render" method allows you to pass a :spacer_template to render a partial between each item in the collection.
<%= render :partial => @items, :spacer_template => 'item_divider' %>
This is good for complex spacers, but sometimes you have a very simple spacer. Like ", " or "<hr />". For these cases, it seems silly to make an external partial which just has this tiny fragment. Even the name of the partial is longer than the contents.
This patch adds a :spacer option which will just take a string.
<%= render :partial => @items, :spacer => "<hr />" %>
You can get that HTML out of the string with the tag method.
<%= render :partial => @items, :spacer => tag(:hr) %>
Much prettier.
Comments and changes to this ticket
-
Pratik August 21st, 2008 @ 03:33 PM
- → State changed from “new” to “wontfix”
I think spacer templates might be better served as a plugin. Very few people actually use them. We might as well remove it from core if the plugin becomes defacto implementation.
Thanks.
-
Ryan Bates August 21st, 2008 @ 07:03 PM
I agree many people don't use spacer_template, but I would certainly use this :spacer option more. I need this behavior in almost every project but find other work-arounds because a spacer template just feels so ugly.
I'm willing to make a plugin with this behavior, but I don't see how it would be possible without re-implementing the entire "render_partial_collection" method. That isn't a good solution.
Any ideas?
-
Jeremy Weiskotten August 21st, 2008 @ 08:25 PM
@Ryan, I think it would be a good addition to the better_partials plugin. There are some other good ideas in there.
-
Ryan Bates August 21st, 2008 @ 09:02 PM
The better_partials plugin is just a wrapper around "render", so it faces the same problem. There's no way to add a spacer as a string without re-implementing the render_partial_collection method.
-
Ryan Bates August 22nd, 2008 @ 01:02 AM
I added ticket #881 which does some refactoring to ActionView::Partials. Then it will be easier for plugins to override render_partial_collection and support more options.
This also makes it easier to remove the spacer_template option if you ever decide to in the future.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
