PATCH: assign collection counter local variable in partials based on the :as option
Reported by Tekin | August 14th, 2008 @ 11:24 PM | in 2.x
A simple patch that adds a collection_size local variable to partial collections. Usefully specifically when you want to know if you are rendering the last item in the collection.
Also assigns a counter based on the :as option if it's set.
Comments and changes to this ticket
-
-
-
Tom Ward August 15th, 2008 @ 02:52 PM
Might it be nicer to automatically provide a helper method/instance variable to indicate whether the first or last records in the collection are being passed?
-
Tekin August 15th, 2008 @ 04:38 PM
- no changes were found...
-
Tekin August 15th, 2008 @ 04:38 PM
I guess so. In fact, Michael's patch does just that!
I've combined Michael's patch with mine, attached.
-
DHH August 16th, 2008 @ 05:29 AM
- → State changed from “new” to “wontfix”
I'm really not a fan of this auto-setting of locals. I think setting the counter local is already kinda fishy, but at least it's something that would otherwise be kinda hard. Setting the size of the collection is perfectly doable through current means, so I don't think it's worth the magic spell to do it automatically.
You're of course always free to turn it into a plugin ;)
-
Tekin August 16th, 2008 @ 11:05 AM
- → Title changed from “PATCH: assign collection_size local variable in partials” to “PATCH: assign collection counter local variable in partials based on the :as option”
A small part of the patch might still be worth keeping though - the part that creates a counter based on the :as parameter. It doesn't feel right that specifying the :as option doesn't set "#{:as}_counter". I've attached another patch.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
