ActiveRecord::Base refactoring
Reported by Clemens Kofler | August 19th, 2008 @ 11:30 PM | in 2.x
While checking out the terrain for another bigger fix, I stumbled across a little inconsistency in AR::Base.
In the SQL builder methods, add_joins!, add_limit! and add_lock! currently take the full options hash whereas their siblings, add_conditions!, add_order! and add_group! take only their relevant attribute. While I see why add_limit! needs to do that (it may take both, :limit and :offset), add_lock! and add_joins! only use their respective options and no other one.
I therefore propose the attached patch to always (and therefore consistently) pass in the full options hash. Although it's only an internally used, private method I think that consistency is still important.
All existing tests pass (apart from the two tests that seem to be failing anyways in the current Edge).
Comments and changes to this ticket
-
Pratik August 20th, 2008 @ 12:48 AM
- → State changed from “new” to “wontfix”
Don't really see any benefits of this. Maybe this could be done whenever those methods need to access other option values.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
