fix count_records
Reported by Xavier Noria | August 19th, 2008 @ 11:54 PM | in 2.x
This is a patch related to this thread in rubyonrails-core.
In a has many association count_records basically counts by SQL. If there are no children in the database it assumes that's enough to say there are no children at all. That's not necessarily the case because the association could have new records in @target.
There are several ways to observe this behaviour, for example rendering a collection that has only new records (via #build) would render nothing at all.
This minimal test depicts the issue as well:
post = Post.create
post.comments.build
post.comments.size # => 1
post.comments.size # => 0
The fix turns out to be simple. I've added a regression test as well.
The documentation I mention in a comment will eventually be merged from this patch in docrails.
Comments and changes to this ticket
-
Xavier Noria August 20th, 2008 @ 12:22 AM
Patch updated with Fred's proposal. That one is better because we certainly can assert
loadedanyway. -
Frederick Cheung August 20th, 2008 @ 11:33 AM
Looks good to me, tests pass. Perhaps the assert should assert that the size is 1 (or is that already covered by existing tests ?
-
Xavier Noria August 20th, 2008 @ 11:55 AM
Yeah, the test assumes size1 is correct because there are unit tests for #size in test_build and test_collection_size_after_building.
-
Tarmo Tänav August 20th, 2008 @ 06:49 PM
I don't think it's necessary to refer to google groups threads in a comment. Either explain the issue in a comment (if it really needs explaining) or don't add a comment. When the patch is commited the added code will already be tied to the commit (git annotate) which will refer to this ticket which already refers to the google groups thread.
Other than that, +1
-
Repository August 21st, 2008 @ 03:51 PM
- → State changed from “new” to “resolved”
(from [a970f916fb1e05376733e2d42d9bcc2b873af355]) Fix has_many#count_records. [#865 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
-
Repository August 25th, 2008 @ 09:31 AM
(from [0048f558e69cfc2675552dd31ea773b2b8271e9b]) Fix has_many#count_records. [#865 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
