:table_name_with_underscore behavior is inconsistent between migrations and find.
Reported by Morgan Schweers | August 20th, 2008 @ 08:04 PM | in 2.x
Greetings,
In schema_statements.rb#create_table it defines the primary key using the table name as the base name.
If we posit an accounts table, using :table_name_with_underscore, this means it will create a primary key of (for example) accounts_id.
When actually referencing that table from an ActiveRecord object, via Account.find(1) it will fail, because it is trying to use a primary key based off the class name, which is singular, and so will do a select for account_id.
I believe the singular is what most folks would expect the table name to come out as (accounts table has an account_id as the primary key), but one way or another the two portions are inconsistent.
Here's a shot at a patch, including fixes for the two migrations tests that use that feature. One thing I'm not sure of is if this patch needs to take into account the table pluralization setting.
I'm throwing this over to Jeremy Kemper, as the last person to touch the line I've changed in create_table. My apologies if that's the wrong person.
-- Morgan Schweers
Comments and changes to this ticket
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
Jeremy Kemper