dynamic finder refactoring and bang version
Reported by Josh Susser | August 26th, 2008 @ 05:37 AM | in 2.2
This patch includes two commits:
1) An extract-class refactoring of the dynamic finder name matching code from AR::Base. The matching code is now in DynamicFinderMatch, which simplifies things a bit.
2) The ability to add a bang to a simple find_by dynamic finder. Person.find_by_name!("Josh") will raise a RecordNotFound error instead of returning nil.
Both commits include appropriate tests.
Comments and changes to this ticket
-
Joshua Peek August 26th, 2008 @ 06:17 AM
- → Milestone changed from “2.x” to “2.2”
- → State changed from “new” to “open”
- → Assigned user changed from “” to “Jeremy Kemper”
+1
-
Repository August 26th, 2008 @ 07:34 AM
- → State changed from “open” to “resolved”
(from [1092c181b5568d06e84f6a3253aaca81c02a2b2c]) add dynamic finder bang version to raise RecordNotFound
[#905 state:resolved]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
Jeremy Kemper