Better query for ASSOCIATION_ids
Reported by Bertg | August 26th, 2008 @ 10:58 AM | in 2.2
For has_many relations Imagine we have 2 models: Cart and Item. Cart has many Items.
If we execute the following statement
Cart.first.item_ids
we get the following query
SELECT * FROM `items` WHERE (`items`.cart_id = 1)
This could by retrieving only an array, and not the objects.
SELECT `items`.id FROM `items` WHERE (`items`.cart_id = 1)
For has_many :through relations Imagine 3 models: User, Membership, Account
The User has many accounts trough membership and vice versa. We define the fitted relations and Execute the following query
User.first.account_ids
This will create the following query
SELECT `accounts`.* FROM `accounts` INNER JOIN memberships ON accounts.id = memberships.account_id WHERE ((`memberships`.user_id = 1))
While the following query would be a lot more efficient (only retrieving an array, not the objects):
SELECT `memberships`.account_id FROM memberships WHERE ((`memberships`.user_id = 1))
What do you think?
Comments and changes to this ticket
-
miloops August 30th, 2008 @ 10:25 PM
- → Tag changed from activerecord eager_loading enhancement has_many joins to activerecord eager_loading enhancement has_many joins patch
I attach the patch that does this, selecting only ids when the association hasn't been loaded, but in case you have already loaded the records, just map the ids has done before and prevent Rails of doing an extra query.
I also removed trailing whitespaces in the test file.
-
Jeremy Kemper August 30th, 2008 @ 11:02 PM
- → State changed from new to open
- → Milestone changed from 2.x to 2.2
- → Assigned user changed from to Jeremy Kemper
The test covers has_many only, but the change affects habtm and has_many :through also.
-
miloops August 30th, 2008 @ 11:20 PM
Added the tests for has_many :through and has_and_belongs_to_many.
-
Bertg August 31st, 2008 @ 12:40 AM
This patch will fail if an other column is defined as the id column.
The 'self.class.primary_key' property should be used...
-
Jeremy Kemper August 31st, 2008 @ 12:58 AM
First patch was applied in http://github.com/rails/rails/co...
Could you rebase the fix against master?
-
miloops August 31st, 2008 @ 01:16 AM
Bertg, you are right i missed that, i attach the patch that applies on top of the first one, since it is already applied, and fix the reported issue.
-

Repository August 31st, 2008 @ 01:40 AM
- → State changed from open to resolved
(from [6183e55f714b436335dc843528be7525c342d922]) Use reflection primary_key instead of id for when selecting association ids.
[#906 state:resolved]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
