Layout MIME type should match the response's
Reported by Roman Le Négrate | August 26th, 2008 @ 11:00 PM | in 2.x
Given layout.html.erb and layout.js.erb, GET /index.js should cause layout.js.erb to be picked as the layout.
This fails to happen if index.js.erb tries to render a partial of another type inside itself (for example: _list.html.erb), in which case layout.html.erb is mistakenly picked.
I attached a failing test covering this bug.
Comments and changes to this ticket
-
Roman Le Négrate August 26th, 2008 @ 11:26 PM
- no changes were found...
-
Roman Le Négrate August 26th, 2008 @ 11:26 PM
Re-uploaded the failing test as there was a typo in the failing assertion.
-
Roman Le Négrate August 27th, 2008 @ 02:11 AM
Uploaded a second patch: the same test that was failing, along with an attempt at solving the problem.
The
mime_responds_test.rbtest suite now passes when run alone.Unfortunately, when running the full ActionPack test suite, another assertion fails inside the new test, for no apparent reason.
The only change I made is to remove the line
@template_format = :htmlinActionView::Base#pick_template. I don't understand what goes wrong when running the full suite; hopefully somebody can help me on this. -
Roman Le Négrate August 27th, 2008 @ 02:15 AM
- no changes were found...
-
-
Joshua Peek August 29th, 2008 @ 05:01 PM
- → State changed from “new” to “open”
- → Tag changed from “2.1 actionpack bug controller edge patch tested tests” to “actionpack”
+1 if you can get it working.
NOTE: test_layout_mime_should_match_responses should be broken up into separate cases
-
Roman Le Négrate August 30th, 2008 @ 10:38 PM
Joshua:
The 2nd patch fixes the bug as the (new) test passes. Plus, I use Rails with this patch applied in one of my projects and I noticed that that bug is now actually gone.
What is weird though, is that when the test suite is run in its entirety, an assertion within the same test (but different from the one which failed originally) then fails. Like some other test messed with the code and did not restore it to its original state afterward.
"test_layout_mime_should_match_responses should be broken up into separate cases": agreed.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
