render partial :object => nil with instance variable
Reported by Erik Andrejko | August 28th, 2008 @ 02:51 PM | in 2.x
The following does not work as expected.
Controller:
@profile = Profile.new
View:
render :partial => 'profile', :object => nil
Inside the partial 'profile', the local variable will be given the value of '@profile' and not nil as expected.
Comments and changes to this ticket
-
Michael Koziarski August 28th, 2008 @ 03:21 PM
- → Assigned user changed from “” to “Joshua Peek”
-
Joshua Peek August 28th, 2008 @ 04:41 PM
- → State changed from “new” to “resolved”
I agree with you thats its a bit of a quirk, but its not easily fixed without alot of complex nil checking.
The implicit assignment is rather old anyway. Instead, I am just going to deprecate it. Sorry that it doesn't immediately fix your issue.
-
Erik Andrejko August 28th, 2008 @ 07:51 PM
Thanks for the fix. I was able to avoid this issue by restructuring my application.
Did you look at the attached patch? It is not that difficult to allow explicit nil assignments. I'm not sure if the implicit assignment of the instance variable should be deprecated or not. Is there any sense of how often this is used?
-
Joshua Peek August 29th, 2008 @ 06:28 AM
I saw the patch. If we wanted to go that route we'd have to add nil overrides to :locals, and :as. I'd really hate to see a big chain of has_key? just because we can't rely on nil.
Implicit assignment is really old school. Infact, I can't even find it documented anywhere. We now have plenty of options to assign objects to the partial local. So I'm not too worried about the people who used to use it.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
