Invalid: dirty AR attributes should be retained if save fails
Reported by chrisbloom7 | August 29th, 2008 @ 12:58 AM | in 2.x
When saving a record, AR (via the Dirty module) will clear all dirty attributes regardless of the result of the save operation. It would make more sense if these attributes were only cleared upon a successful save. This way, if a save operation fails any helper functions can still tell if a value is dirty after Rails falls back through to the edit/create page.
Here's an example using the console
>> p = Project.new
=> #<Project:0x4735d6c>
>> p.changed
=> []
>> p.id = 1
=> 1
>> p.changed
=> ["id"]
>> p.save
=> false
>> p.changed
=> []
Comments and changes to this ticket
-
chrisbloom7 August 29th, 2008 @ 01:04 AM
- → Title changed from “dirty AR attributes should be retained if save fails” to “Invalid: dirty AR attributes should be retained if save fails”
- → Tag changed from “activerecord dirty” to “invalid”
Never mind, I see in the latest revision this is done
-
Jeremy Kemper August 29th, 2008 @ 01:39 AM
- → State changed from “new” to “invalid”
- → Tag cleared.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
