1
true
2008-08-29T11:50:02+01:00
8163
9903
932
validates_uniqueness_of-is-unicode-unaware
382
8994
resolved
activerecord bug patch tiny
validates_uniqueness_of is unicode unaware
2008-08-29T20:01:53+01:00
17393
Repository
Eugene Pimenov
http://rails.lighthouseapp.com/projects/8994/tickets/932
2.x
Validate_uniqueness in case insensitive mode use downcase which is unicode-unaware. With an unicode aware database, lower(field) != downcased value so it fails to validate anything.
The patch is a simple one-liner.
In the test “Topic.find(t_utf8, :select => 'LOWER(title) AS title').title == "я тоже уникальный!"” checks unicode awareness of database. For example, In MySQL “alter database activerecord_unittest charset=utf8” make this condition true, and “alter database activerecord_unittest charset=latin1” make it false.
Validate_uniqueness in case insensitive mode use downcase which is unicode-unaware. With an unicode aware database, lower(field) != downcased value so it fails to validate anything.
The patch is a simple one-liner.
In the test “Topic.find(t_utf8, :select => 'LOWER(title) AS title').title == "я тоже уникальный!"” checks unicode awareness of database. For example, In MySQL “alter database activerecord_unittest charset=utf8” make this condition true, and “alter database activerecord_unittest charset=latin1” make it false.
<div><p>Validate_uniqueness in case insensitive mode use downcase which
is unicode-unaware. With an unicode aware database, lower(field) !=
downcased value so it fails to validate anything.</p>
<p>The patch is a simple one-liner.</p>
<p>In the test “Topic.find(t_utf8, :select =>
'LOWER(title) AS title').title == "Ñ
тоже
уникальный!"â€
checks unicode awareness of database. For example, In MySQL
“alter database activerecord_unittest
charset=utf8†make this condition true, and
“alter database activerecord_unittest
charset=latin1†make it false.</p></div>
0
Validate_uniqueness in case insensitive mode use downcase which is unicode-unaware. With an unicode aware database, lower(field) != downcased value so it fails to validate anything.
The patch is a simple one-liner.
In the test “Topic.find(t_utf8, :select => 'LOWER(title) AS title').title == "я тоже уникальный!"” checks unicode awareness of database. For example, In MySQL “alter database activerecord_unittest charset=utf8” make this condition true, and “alter database activerecord_unittest charset=latin1” make it false.
<div><p>Validate_uniqueness in case insensitive mode use downcase which
is unicode-unaware. With an unicode aware database, lower(field) !=
downcased value so it fails to validate anything.</p>
<p>The patch is a simple one-liner.</p>
<p>In the test “Topic.find(t_utf8, :select =>
'LOWER(title) AS title').title == "я
тоже
уникальный!"”
checks unicode awareness of database. For example, In MySQL
“alter database activerecord_unittest charset=utf8”
make this condition true, and “alter database
activerecord_unittest charset=latin1” make it false.</p></div>
false
2008-08-29T11:50:04+01:00
8163
--- {}
9903
932
validates_uniqueness_of-is-unicode-unaware
0
8994
new
activerecord bug patch tiny
validates_uniqueness_of is unicode unaware
2008-08-29T11:50:04+01:00
8163
Eugene Pimenov
Eugene Pimenov
http://rails.lighthouseapp.com/projects/8994/tickets/932
2.x
1
Nice!
+1
<div><p>Nice! +1</p></div>
false
2008-08-29T13:40:10+01:00
8163
--- {}
9903
932
validates_uniqueness_of-is-unicode-unaware-2
0
8994
new
activerecord bug patch tiny
validates_uniqueness_of is unicode unaware
2008-08-29T13:40:10+01:00
19965
José Valim
Eugene Pimenov
http://rails.lighthouseapp.com/projects/8994/tickets/932
2.x
1
http://github.com/rails/rails/commit/743f0e7114b071bf7786a80227c12dcc7ccee6c1
<div><p><a href="http://github.com/rails/rails/commit/743f0e7114b071bf7786a80227c12dcc7ccee6c1">
http://github.com/rails/rails/co...</a></p></div>
true
2008-08-29T19:49:16+01:00
8163
---
:state: new
9903
932
validates_uniqueness_of-is-unicode-unaware-3
0
8994
resolved
activerecord bug patch tiny
validates_uniqueness_of is unicode unaware
2008-08-29T19:49:16+01:00
14890
Tarmo Tänav
Eugene Pimenov
http://rails.lighthouseapp.com/projects/8994/tickets/932
2.x
1
(from [184ae2ccb49f0e408fe7d9ba7fe2d1bc5470bc8a]) Make case insensitive validates_uniqueness_of use unicode aware downcase method. [#932 state:resolved]
Signed-off-by: Michael Koziarski <michael@koziarski.com>
Conflicts:
activerecord/lib/active_record/validations.rb
Signed-off-by: Tarmo Tänav <tarmo@itech.ee>
http://github.com/rails/rails/commit/184ae2ccb49f0e408fe7d9ba7fe2d1bc5470bc8a
<div><p>(from [184ae2ccb49f0e408fe7d9ba7fe2d1bc5470bc8a]) Make case
insensitive validates_uniqueness_of use unicode aware downcase
method. [<a href="/projects/8994/tickets/932" title="Ticket #932">#932</a> state:resolved]</p>
<p>Signed-off-by: Michael Koziarski <a href="mailto:michael@koziarski.com">michael@koziarski.com</a></p>
<p>Conflicts:</p>
<pre>
<code>activerecord/lib/active_record/validations.rb
</code>
</pre>
<p>Signed-off-by: Tarmo Tänav <a href="mailto:tarmo@itech.ee">tarmo@itech.ee</a> <a href="http://github.com/rails/rails/commit/184ae2ccb49f0e408fe7d9ba7fe2d1bc5470bc8a">
http://github.com/rails/rails/co...</a></p></div>
true
2008-08-29T20:01:53+01:00
8163
--- {}
9903
932
validates_uniqueness_of-is-unicode-unaware-4
0
8994
resolved
activerecord bug patch tiny
validates_uniqueness_of is unicode unaware
2008-08-29T20:01:53+01:00
17393
Repository
Eugene Pimenov
http://rails.lighthouseapp.com/projects/8994/tickets/932
2.x
b309e10548677614a3ff3ffa3552a428aa0c7ea8
text/plain
2008-08-29T11:50:04+01:00
0001-Make-case-insensitive-validates_uniqueness_of-use-un.patch
42497
2050
8163
http://rails.lighthouseapp.com/attachments/42497/0001-Make-case-insensitive-validates_uniqueness_of-use-un.patch