Remove 'Object#send!'
Reported by Hongli Lai | August 31st, 2008 @ 06:25 PM | in 2.2
'Object#send!', as defined in active_support/core_ext/object/misc.rb, was originally added because Ruby 1.9 has such a method as well. Object#send! has been removed from Ruby 1.9 since November 2007.
Furthermore, using 'Object#send!' can break Delegate classes such as Tempfile, though it depends on the load order. Delegate delegates all methods to its underlying object. If Object#send! is defined before Tempfile was defined, then Tempfile will think that its underlying File object has a 'send!' method. Thus, calling Tempfile#send!(:size) will result in Tempfile calling File#send!(:size). File#size doesn't exist, so a crash will occur as a result. What should have happened is that Tempfile#size is called. But since Object#send! was defined before Tempfile was defined, Tempfile (or rather, Delegate) will override 'send!' and replace it with a version that forwards the call to File.
The attached patch removes 'Object#send!'.
Comments and changes to this ticket
-
Jeremy Kemper August 31st, 2008 @ 09:28 PM
- → State changed from “new” to “resolved”
- → Milestone changed from “2.x” to “2.2”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
