Patching Rails
Reported by soleone (at gmail) | May 25th, 2008 @ 06:38 PM
Today I found about the *inplace_editing plugin*, which looks really nice, but has some issues as highlighted in this Screencast.
-
The new request forgery protection is not considered by the plugin, so you have to manually change _in_place_editing/lib/in_place_macros_helper.rb_, or disable protection in the controller for
inplace_edit_for - The option externalControlOnly is not included in the helper (but available on the JS-side), and also not mentioned in the rdoc
I would add it myself, but I am kinda new to this and couldn't find the project on Github (which would make it easy to contribute).
If someone would give me a hint on how to contribute, I'd do it myself. Or maybe there are reasons not to implement these changes? At least the second seems trivial and a must have.
Greetings, Soleone
Comments and changes to this ticket
-
Damien McKenna May 29th, 2008 @ 02:35 PM
- → Title changed from “Inplace Editing for Rails 2.0” to “Patch available for CSRF issue”
FYI a patch was posted to trac:
-
Damien McKenna May 29th, 2008 @ 02:35 PM
- → Title changed from “Patch available for CSRF issue” to “Inplace Editing for Rails 2.0”
(doh, sorry about the title)
-
Ed Lebert June 11th, 2008 @ 04:41 PM
Can someone tell me how to apply a patch file to rails? I seriously have spent 3 hours on google figuring out how to apply the patch from trac ticket http://dev.rubyonrails.org/ticke....
-
paddor (at gmail) November 7th, 2008 @ 10:22 AM
- → Title changed from “Inplace Editing for Rails 2.0” to “Patching Rails”
@Ed Lebert: http://rails.lighthouseapp.com/p...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
