Activity (RSS)

Can you please give me your github username so that I can add you to docrails project ?

Thanks.

Attached is a patch which adds a couple of examples and corrects a spelling error in documentation for HashWithIndifferentAccess.

Here's Aslak's patch -- I had it handy...

Ah. I thought you were worried about id clashes. Do you have the patch handy? I don't see it attached here.

This is not about ids or timestamps at all. It's about two migrations with identical class names. The class in the latest file will overwrite the class in the ...

With auto-incrementing ids, collision was guaranteed. With the timestamp ids, you have to be creating the same migration at the very same second for a collisio...

Steve taught me off line how to make a fix on a branch - I'll do that next time!

I'm http://github.com/jnewland/

Thanks!

Jesse, could u please give me your github username so that I can add you to docrails project ?

Thank you, applied in http://github.com/lifo/docrails/....

This tiny patch documents passing a block to JavaScriptGenerator#call as well as JavaScriptGenerator's method_missing proxy to JavaScriptProxy. These two power...

Excellent, applied in http://github.com/lifo/docrails/....

Attached find a small but useful documentation path. Explains how and when to use the previously-undocumented clear_query_cache method, including discussion of...

Erik, could u please give me your github username so that I can add you to docrails project ?

Thank you, applied in http://github.com/lifo/docrails/....

Just a simple whitespace fix to align comments

time_zone_parse.diff is attached, a new patch that works as Geoff advertised, replacing #to_time with Time.zone.parse.

Thanks for the advice.

The time zone enhancement to String#to_time does make sense, but it might break apps that rely on the existing behavior (i.e., ignore any time zone info in the...

See the patch I attached :-)

D'oh, somehow manager to produce a patch with not the final version (and mix that in with a patch from another ticket I'd applied locally to test - no idea how...

I believe this does the trick. Would be good for those bitten by this to try it out

CookieStore is currently escaping and unescaping while this is handled in other places in ActionController. This means double the work which does, in some case...

This patch includes the methods alter_charset, add_foreign_key_constraint, drop_foreign_key_constraint, and grant_access.

Well [http://dev.rubyonrails.org/ticke...][this ticket] is why the current behaviour is what it is. I can't think off the top of my head whether that the ticke...

When association is declared in superclass eager loading of this association produces one query for each subclass. Example:

Update edge Rails and generate emp...

Patch with a unit test demonstrating this nested array behaviour.

Say you have a form with fields for creating several contacts; each contact has fields for several phone numbers. The html might look like this:

<!-- first co...

I think giving the method a different name is appropriate, and at a minimum the tests should be carried over.

The method you are looking for already exists:

Shirt.colored('red').proxy_options

Unless you're asking for the name to be changed/aliased to scope_options yo...

I fear you've rather got the wrong end of the stick. :joins just write out all those joins for you, nothing else (prior to 2.0 you'd just write out the joins y...

Well, damn... You are correct. :joins actually works in this case. No reason why :include shouldn't work as well though. Rather misleading thinking that they c...

That's the way it's always been as far as I know. Sounds like you just want :joins instead of :include.

We changed the migration names in edge to run off timestamps instead to avoid duplicates.

We used to have a very full-fledged set of assets, but cut them down because the value they offered wasn't worth the hassle of trying to figure out when to use...

Thanks, all set!

I've added your account to commit list of docrails - http://github.com/lifo/docrails/...

Please commit the patch there yourself :)

Various corrections, improvements, and clarifications to the page caching documentation, such as some coverage for apps which generate XML/RSS pages.

This pat...

We took a slightly different approach to the same sorts of problems in ticket 121. Our goal with assert_showing_flash was to confirm that the app uses flash v...

No good reason... I've just started using git, so I'm still working out how to do some of these kinds of operations.

Thank you. Is there a good reason for not squishing the commits in the patch?

Ok, here's the updated patch that makes additional parameters optional.

Updating attachment

The newly attached patch interprets strings without time zone information as being in the current time zone.

If you have a fixture name which does not match the table name for the associated model, the fixture named accessors will raise an exception like this:

NoMeth...

Ok, so here's a git patch, hope it makes sense. I also ran the full rails test suite and there were no regressions on my machine (rails 2.0.2 with ruby 1.8.6)....