#1386 polymorphic_url should treat an array contains single name as without the container - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1386 ✓committed

polymorphic_url should treat an array contains single name as without the container

Reported by hiroshi | November 16th, 2008 @ 09:20 AM | in 2.x

After I posted #1317, I realized I missed one more feature I want to be patched.

You may see what I want by an excerpt from my new patch.


  def test_with_array_containing_single_name
  @article.save
  expects(:articles_url)
  polymorphic_url([:articles])
end

That it.

single_name.diff 1.8 KB

Comments and changes to this ticket

DHH November 16th, 2008 @ 08:44 PM
I'm not sure I quite understand what this does? What was the behavior before this?

hiroshi November 17th, 2008 @ 02:08 AM

Before this change, the test I added failed.


  1) Error:
test_with_array_containing_single_name(PolymorphicRoutesTest):
NoMethodError: undefined method `articles_nil_class_url' for #<PolymorphicRoutesTest:0x1045528>

However, giving an array consists of an object doesn't raise NoMethodError nor any.


def test_with_array_containing_single_object
  @article.save
  expects(:article_url).with(@article)
  polymorphic_url([nil, @article]) # argument will be [@article] with former patch #1317
end

I wish this explain my intention.

Repository November 19th, 2008 @ 11:07 AM
- State changed from “new” to “committed”
(from [591560c641d52f6a8fb12a26c60c3f812735ac0d]) Let polymorphic_path treat an array contains single name as without array [#1386 state:committed]

Signed-off-by: David Heinemeier Hansson david@loudthinking.com http://github.com/rails/rails/co...
Repository November 19th, 2008 @ 11:07 AM
(from [291d199de1271c254c44b94766d13013b222a125]) Let polymorphic_path treat an array contains single name as without array [#1386 state:committed]

Signed-off-by: David Heinemeier Hansson david@loudthinking.com http://github.com/rails/rails/co...