This project is archived and is in readonly mode.
fix to eager loading on polymorphic associations
We need to be sure to invoke the preload_XXX_associations method on the proper class, otherwise loading polymorphic associations will not work properly. It breaks on polymorphic associations because the polymorphic foreign key uses the local class as the name to use in the where clause (e.g. ['WHERE association_type = ?', class.name]).
-
Frederick Cheungis this the problem you were describing in #546 Error in AR::AssociationPreload::ClassMethods#preload_associations when recor... ?
-
acechaseIt's a similar problem. In #546 Error in AR::AssociationPreload::ClassMethods#preload_associations when recor... the problem was that the records were not being grouped by class at all. Now, records are being grouped by class appropriately, but the #send that's happening after grouping is using the class the module is being included in, rather than the class the records are from.
-
Jeremy Kemper- Assigned user set to Jeremy Kemper
- State changed from new to open
- Milestone cleared.
-
Jeremy Kemper
Nice catch. Needs a test case :)
-
Jeremy Kemper
- State changed from open to stale