This project is archived and is in readonly mode.
find_in_batches updates (+2 bugs)
-
eric.tipton (at gmail)
updated to account for bug 2128
-
eric.tipton (at gmail)
bug 2128 URL: http://rails.lighthouseapp.com/p...
-
Frederick Cheung
- State changed from new to incomplete
Hi eric,
thanks for the work you've done, however you should check out the contributor guide ( https://rails.lighthouseapp.com/... ). When you just submit an entire file like that it's harder to see the changes you've made (and potentially easy to squash other updates to batches.rb)
I'd also really recommend you separate out your bug fixes from the non bug changes you've made
-
Matthew Beale
I've got the scope fix in:
https://rails.lighthouseapp.com/projects/8994/tickets/2227-batches-...
With tests and all.
Also peeps on the same/similar topic:
https://rails.lighthouseapp.com/projects/8994/tickets/2128-activere...
