This project is archived and is in readonly mode.

#2328 ✓stale
Greg Weber

named_scope sum should delegate to Enumerable

Reported by Greg Weber | March 24th, 2009 @ 03:32 PM | in 3.x

The sum method in named_scope assumes ActiveRecord sum. There may be other enumerable conflicts.

I am currently using the following implementation for sum

  # sum with a block goes to Enumerable, otherwise it is an ActiveRecord calculation
  def sum(*args, &block)
    if block
      proxy_found.sum(*args, &block)
    end || 0

Comments and changes to this ticket

  • Frederick Cheung

    Frederick Cheung May 8th, 2009 @ 12:08 AM

    Personally i think that named_scope's sum being an activerecord sum is the right thing - scopes generally behave almost exactly like the original class, just with extra conditions, order etc... (much like associations)

    Uou can always force the named_scope to an array and call sum on that if you really want Enumerable's sum

  • Greg Weber

    Greg Weber May 13th, 2009 @ 07:13 AM

    I have the same implementation now for Enumerable#count. The main problem with the idea behind this ticket would be if someone extended ActiveRecord sum or count to use blocks, it wouldn't work. to_a is a reasonable solution.

  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:40 PM

    • State changed from “new” to “open”
    • Importance changed from “” to “”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:40 PM

    • State changed from “open” to “stale”
  • klkk

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket