Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

counter cache can be set as optional

#2499

probl: we have to models: class Tagging < ActiveRecord::Base belongs_to :taggable, :polymorphic => true, :counter_cache => true end

class Item < ActiveRecord::Base has_one :tagging, :as => :taggable end

In this situation, any other associations of Tagging are fine (as long as they have counter column). There is no need to have it on Item, but it throws: Exception raised: Class: <ActiveRecord::StatementInvalid> Message: <"Mysql::Error: Unknown column 'taggings_count' in 'field list': UPDATE items SET taggings_count = COALESCE(taggings_count, 0) + 1 WHERE (id = 2) ">

(it's in the test in attached patch)

This patch fixes that, allowing user to specify :counter_cache_optional => true

The default behavior is unaltered. Tested for MySQl and SQLite3 but should make no difference on db layer anyway.

Reported by krzys (at kristoff) · April 15th, 2009 @ 04:03 PM

State: stale
Milestone: 3.x
Assigned to: nobody
Importance: none

Activity

  1. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.x to 3.x

    May 4th, 2010 @ 06:48 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Importance changed from to

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 05:03 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 05:03 PM