Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

question and serialized attribute methods should raise ActiveRecord::MissingAttributeError.

#2763

When doing a find and specifying :select, ActiveRecord will raise a MissingAttributeError if you try to access an attribute that wasn't included in the :select.

It will not, however, raise that error if you access serialized attributes or the question method of a boolean attribute. This patch fixes that (and adds tests to cover it).

Given this ActiveRecord model:

class User < ActiveRecord::Base
  # column :name, :string
  # column :data, :text
  # column :active, :boolean


serialize :data end

And this database record:

User.create!(:name => 'Bob', :data => [], :active => true)

Before this patch:

u = User.find(:first, :select => 'id')
u.name #=> raises ActiveRecord::MissingAttributeError
u.active #=> raises ActiveRecord::MissingAttributeError
u.active? #=> nil
u.data #=> nil

After this patch:

u = User.find(:first, :select => 'id')
u.name #=> raises ActiveRecord::MissingAttributeError
u.active #=> raises ActiveRecord::MissingAttributeError
u.active? #=> raises ActiveRecord::MissingAttributeError
u.data #=> raises ActiveRecord::MissingAttributeError

Reported by Bob Zoller · June 5th, 2009 @ 01:29 AM

State: stale
Milestone: 3.x
Assigned to: Rohit Arondekar Rohit Arondekar
Importance: Low

Activity

  1. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.x to 3.x

    May 4th, 2010 @ 06:48 PM

  2. Rohit Arondekar
    Rohit Arondekar
    • State changed from new to open
    • Assigned user set to Rohit Arondekar
    • Importance changed from to Low

    This still happens on Rails 3. Could you rebase/re-write the patch?

    October 15th, 2010 @ 11:13 AM

  3. Santiago Pastorino
    Santiago Pastorino
    • Tag changed from 2.x, active_record, patch to 2x, active_record, patch

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:30 PM

  4. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:30 PM

  5. bingbing