This project is archived and is in readonly mode.
In databases.rake, drop_database missing else-clause
Reported by apeiros | September 9th, 2009 @ 01:17 PM
In http://github.com/rails/rails/blob/c3accd7ded9ceaaecad55a2b04940e1f... - the drop_database method uses a case/when to determine how to drop the database. It SHOULD have an else-clause reporting an unsupported adapter.
Comments and changes to this ticket
-
CancelProfileIsBroken September 25th, 2009 @ 12:28 PM
- Tag changed from “2.3.4, db:drop, rake” to “2.3.4, bugmash, db:drop, rake”
-
Daniel Hofstetter September 26th, 2009 @ 04:43 PM
- no changes were found...
-
Daniel Hofstetter September 26th, 2009 @ 04:45 PM
The patch adds the missing else-clause and raises an error in it.
-
Daniel Hofstetter September 26th, 2009 @ 04:55 PM
- Tag changed from “2.3.4, bugmash, db:drop, rake” to “2.3.4, bugmash, bugmash-patch, bugmash-review, db:drop, rake”
-
-
Blue Box Jesse September 26th, 2009 @ 11:35 PM
+1
2.3-stable patch applies successfully.
Good idea and good fix.
-
-
CancelProfileIsBroken September 27th, 2009 @ 12:01 PM
- Tag changed from “2.3.4, bugmash, bugmash-patch, bugmash-review, db:drop, rake” to “2.3.4, bugmash-patch, bugmash-review, db:drop, rake”
-
Lenary April 18th, 2010 @ 01:14 AM
- Tag changed from “2.3.4, bugmash-patch, bugmash-review, db:drop, rake” to “2.3.4, bugmash-patch, bugmash-review, db:drop, patch, rake”
-
Lenary April 18th, 2010 @ 01:16 AM
- Tag changed from “2.3.4, bugmash-patch, bugmash-review, db:drop, patch, rake” to “2.3.4, bugmash-patch, bugmash-review, db:drop, incomplete, rake”
There seems to be no reason why this has not yet been fixed.
In the meantime though, the problem still persists, but the files have moved quite a lot.
the file you are all referring to is now located here in rails 3:
http://github.com/rails/rails/blob/master/activerecord/lib/active_r...
(i have not evaluated the patches for correctness or otherwise)
good fix though!
-
-
Rizwan Reza May 15th, 2010 @ 06:45 PM
- Tag changed from “2.3.4, bugmash-patch, bugmash-review, db:drop, incomplete, rake” to “2.3.4, bugmash, bugmash-patch, db:drop, incomplete, rake”
-
-
Diego Algorta May 15th, 2010 @ 07:28 PM
Submitting patch for 2-3-stable too. Original Author maintained.
-
-
Jeff Kreeftmeijer May 16th, 2010 @ 12:31 AM
Sorry, that should've been a "+". I completely agree with this patch, I just think it needs some tests. :)
-
Santiago Pastorino February 2nd, 2011 @ 04:38 PM
- State changed from “new” to “open”
- Tag changed from “2.3.4, bugmash, bugmash-patch, db:drop, incomplete, rake” to “234, bugmash, bugmash-patch, dbdrop, incomplete, rake”
- Importance changed from “” to “”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 04:38 PM
- State changed from “open” to “stale”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
apeiros
Neeraj
Ryan Bigg