Rails Ruby on Rails → 2.3.6

Comments and changes to this ticket

• You flagged this item as spam.
  

  Bruno Michel November 1st, 2009 @ 01:08 PM

  • Tag changed from “2-3-stable, xss” to “2-3-stable, patch, xss”

• You flagged this item as spam.
  

  Bruno Michel November 10th, 2009 @ 10:51 PM

  No news on this ticket?

• 

  Michael Koziarski November 30th, 2009 @ 08:36 PM

  • Milestone set to “2.3.6”
• 

  Santiago Pastorino March 8th, 2010 @ 08:56 PM

  • State changed from “new” to “open”

  Yes, you're right Bruno.
  First of all can you provide a failing test case?, and must say that your patch is wrong you're not on the current 2-3-stable branch.

  The actual code is:

  "<form method=\"#{form_method}\" action=\"#{escape_once url}\" class=\"button-to\"><div>" +
    method_tag + tag("input", html_options) + request_token_tag + "</div></form>".html_safe
  

  and should be:

  ("<form method=\"#{form_method}\" action=\"#{escape_once url}\" class=\"button-to\"><div>" +
     method_tag + tag("input", html_options) + request_token_tag + "</div></form>").html_safe
  

  not that is html_safe not html_safe!

• You flagged this item as spam.
  

  Bruno Michel March 8th, 2010 @ 10:06 PM

  and must say that your patch is wrong you're not on the current 2-3-stable branch.

  Hey, I was on the 2-3-stable when I created the patch in October last year ;-) But html_safe! has been deprecated in favor of html_safe since (in January IIRC).

  First of all can you provide a failing test case?

  Sure, I've attached the new patch with a unit test.

• You flagged this item as spam.
  

  Bruno Michel March 8th, 2010 @ 10:06 PM

  and must say that your patch is wrong you're not on the current 2-3-stable branch.

  Hey, I was on the 2-3-stable when I created the patch in October last year ;-) But html_safe! has been deprecated in favor of html_safe since (in January IIRC).

  First of all can you provide a failing test case?

  Sure, I've attached the new patch with a unit test.

  • button_to_20100308.diff 1.7 KB
  • button_to_20100308.diff 1.7 KB

• You flagged this item as spam.
  

  Bruno Michel March 8th, 2010 @ 10:08 PM

  Hum, it looks like lighthouse has buged, and my last comment and patch were posted two times.

• 

  Santiago Pastorino March 9th, 2010 @ 11:12 PM

  • State changed from “open” to “verified”
• 

  Santiago Pastorino March 22nd, 2010 @ 01:56 AM

  • State changed from “verified” to “committed”

• You flagged this item as spam.
  

  bingbing March 26th, 2011 @ 01:42 AM

  omega watch