#4339 params are strings IRL, integers in test - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4339 ✓duplicate

params are strings IRL, integers in test

Reported by mikeymicrophone | April 7th, 2010 @ 07:29 PM

If I'm not mistaken, integer parameters from a web server are always delivered to the controller as strings, but the test helpers #get, #post etc allow you to pass in integers. In my experience this leads to a lot of bugs and it might make sense to align the behavior more accurately.

Comments and changes to this ticket

David Trasbo April 12th, 2010 @ 10:36 AM

This can be duplicated on edge Rails:

class TestsController < ApplicationController
  def show
    render :text => params[:id].class.to_s
  end
end

require 'test_helper'

class TestsControllerTest < ActionController::TestCase
  test "id param is a Fixnum" do
    get :show, :id => 42
    assert_equal 'Fixnum', response.body
  end
end

I definitely think this should be fixed. Since a controller will always receive all parameters as strings in real life, I think all parameters passed from tests should be converted to strings for consistency.

Ryan Bigg April 12th, 2010 @ 11:26 AM
Patch welcome.
Andrew White April 12th, 2010 @ 12:40 PM
This has come up before: #2984
Ryan Bigg April 12th, 2010 @ 09:08 PM
- State changed from “new” to “duplicate”
Duplicate of #2984.